[Rpm-maint] [rpm-software-management/rpm] Use close_range() to set close-on-exec on all fds (PR #4149)

Panu Matilainen notifications at github.com
Tue Mar 24 08:54:56 UTC 2026


@pmatilai requested changes on this pull request.

This is failing to build in CI because of this warning:
> :1791:13: error: unused function 'set_cloexec' [-Werror,-Wunused-function]
1.164  1791 | static void set_cloexec(int fd)

Probably easiest to just ifdef the whole rpmSetCloseOnExec() implementation: the new variant just calls close_range() and the other branch includes the existing loop and the helper function.



-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4149#pullrequestreview-3997359787
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/4149/review/3997359787 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20260324/780b9419/attachment.htm>


More information about the Rpm-maint mailing list