[Rpm-maint] [rpm-software-management/rpm] Implement a separate lock for the keystore (PR #4123)

[Panu Matilainen]

@pmatilai commented on this pull request.



> @@ -153,11 +161,7 @@ int rpmtsRebuildDB(rpmts ts)
 	    rc = rpmdbRebuild(ts->rootDir, NULL, NULL, rebuildflags);
 	rpmtxnEnd(txn);
     }
-    /* Re-create lock file */
-    rpmtsLockFree(ts);
-    txn = rpmtxnBegin(ts, RPMTXN_WRITE);
-    if (txn)
-	rpmtxnEnd(txn);
+    ensureKrlock(ts);

Good catch. I remember moving it out of the txn-if for a reason (both here and in rpmtsInitDB()) but looking at it now, this seems dubious: it can only succeed if txn was non-NULL, so it might as well be inside that block.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4123?email_source=notifications&email_token=ADLPZU2EOKBOAVOY3PFRKA34TNWNXA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMBTGUZDGNJSGE42M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOS6XA4S7OJSXM2LFO5PW433UNFTGSY3BORUW63TTL5RWY2LDNM#discussion_r3013999141
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/4123/review/4035235219 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20260331/95f0a22a/attachment.htm>