[Rpm-maint] [rpm-software-management/rpm] Implement a separate lock for the keystore (PR #4123)

Michal Domonkos notifications at github.com
Tue Mar 31 08:03:32 UTC 2026


@dmnks commented on this pull request.



> @@ -153,11 +161,7 @@ int rpmtsRebuildDB(rpmts ts)
 	    rc = rpmdbRebuild(ts->rootDir, NULL, NULL, rebuildflags);
 	rpmtxnEnd(txn);
     }
-    /* Re-create lock file */
-    rpmtsLockFree(ts);
-    txn = rpmtxnBegin(ts, RPMTXN_WRITE);
-    if (txn)
-	rpmtxnEnd(txn);
+    ensureKrlock(ts);

Oh yep, putting the check inside the txn-if is the way to go here (as opposed to just checking if `ts` is `NULL`).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4123?email_source=notifications&email_token=ADLPZU3GPUK3URO66ER4MND4TN3VJA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMBTGU2DMMJRGA3KM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOS6XA4S7OJSXM2LFO5PW433UNFTGSY3BORUW63TTL5RWY2LDNM#discussion_r3014200645
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/4123/review/4035461106 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20260331/265f432b/attachment.htm>


More information about the Rpm-maint mailing list