[Rpm-maint] [rpm-software-management/rpm] Move rpmuncompress to the standard binary directory (PR #4156)

[Michal Domonkos]

@dmnks commented on this pull request.



> @@ -106,6 +106,7 @@ function(makemacros)
 	set(infodir "\${prefix}/${CMAKE_INSTALL_INFODIR}")
 	set(mandir "\${prefix}/${CMAKE_INSTALL_MANDIR}")
 	set(rundir /run)
+	set(bindir_full ${CMAKE_INSTALL_FULL_BINDIR})

> I'm a bit wary of touching it because it exposes scriptlets to unknown things just depending on what prefix rpm itself was built into. That line has been last touched in 2000, and actually that's the commit where it was introduced in 😳

Yep, that's a valid concern. I thought of the same, actually. Even if that path would be the last component to check, one could still have custom (development) versions of some system binaries *and* not have the original binary installed for some reason, in which case the former would get picked up, with potentially unexpected consequences. So yep, that sounds like a nightmare :sweat_smile: Let's not go there yet.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4156?email_source=notifications&email_token=ADLPZU6BEJ3TW2JQI4CJS5D4TOHV7A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMBTGYYDSOJUGM22M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOS6XA4S7OJSXM2LFO5PW433UNFTGSY3BORUW63TTL5RWY2LDNM#discussion_r3014756300
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/4156/review/4036099435 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20260331/9fa57f13/attachment.htm>