[Rpm-maint] [rpm-software-management/rpm] rpmsign: handle _file_sign_key_id values greater than i32::MAX (PR #4218)

[Jeremy Cline]

@jeremycline commented on this pull request.



> @@ -549,7 +550,14 @@ static rpmRC includeFileSignatures(Header *sigp, Header *hdrp)
     rpmRC rc;
     char *key = rpmExpand("%{?_file_signing_key}", NULL);
     char *keypass = rpmExpand("%{?_file_signing_key_password}", NULL);
-    uint32_t keyid = rpmExpandNumeric("%{?_file_signing_key_id}");
+    auto [ numeric_rc, unclamped_key_id ] = rpm::macros().expand_numeric("%{?_file_signing_key_id}");

My C++ is... pretty much read-only, so I followed along from the existing macros.cc implementation for the i32 variety.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4218#pullrequestreview-4351003238
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/4218/review/4351003238 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20260523/763775ea/attachment.htm>