[Rpm-maint] [rpm-software-management/rpm] Fix build warnings when building with ENABLE_OPENMP=OFF (PR #4311)
Panu Matilainen
notifications at github.com
Thu Sep 3 07:52:51 UTC 2026
@pmatilai requested changes on this pull request.
This cure is worse than the disease. It looks just super confusing to have an omp pragma on the case where no OMP is available. And these ifdef's are really ugly.
Make "i" used instead: add the priority to the debug log entry, it's actually genuinely relevant information there. For non-omp builds, it'll be zero which is equally relevant.
And, drop the -Wno-unknown-pragmas bit. It'd be okay to silence just omp pragmas, but not everything.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4311#pullrequestreview-5099254643
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/4311/review/5099254643 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20260903/a2387d98/attachment.htm>
More information about the Rpm-maint
mailing list