[Rpm-maint] [rpm-software-management/rpm] Fix build warnings when building with ENABLE_OPENMP=OFF (PR #4311)
Shreenidhi Shedi
notifications at github.com
Thu Sep 3 09:14:11 UTC 2026
sshedi left a comment (rpm-software-management/rpm#4311)
> This cure is worse than the disease. It looks just super confusing to have an omp pragma on the case where no OMP is available. And these ifdef's are really ugly.
> Make "i" used instead: add the priority to the debug log entry, it's actually genuinely relevant information there. For non-omp builds, it'll be zero which is equally relevant.
I will try this.
> And, drop the -Wno-unknown-pragmas bit. It'd be okay to silence just omp pragmas, but not everything. If you do a non-omp build, just disable that warning yourself.
It is possible to enable `-Werror` through cmake options, how do you plan to suppress these warnings in that case? It will break the build if Werror is enabled.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4311#issuecomment-5523424378
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/4311/c5523424378 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20260903/e5ce6478/attachment.htm>
More information about the Rpm-maint
mailing list