[Rpm-maint] [rpm-software-management/rpm] Add statvfs(3) support to the Lua posix module (PR #4324)

[Michal Domonkos]

@dmnks commented on this pull request.

Minor documentation nits only, otherwise looks good.

> +	The optional _SELECTOR_ may be one of
+	- *bsize*
+	- *blocks*
+	- *bfree*
+	- *bavail*
+	- *favail*
+	- *ffree*
+	- *files*
+	- *flag*
+	- *frsize*
+	- *fsid*
+	- *namemax*
+
+	If omitted, a table with all these fields is returned.
+
+	*flag* is table with known flag names as keys and booleans as

```suggestion
	*flag* is a table with known mount flag names as keys and booleans as
```

> +	- *bsize*
+	- *blocks*
+	- *bfree*
+	- *bavail*
+	- *favail*
+	- *ffree*
+	- *files*
+	- *flag*
+	- *frsize*
+	- *fsid*
+	- *namemax*
+
+	If omitted, a table with all these fields is returned.
+
+	*flag* is table with known flag names as keys and booleans as
+	values. This way it's possible to differentiate unsupported flags

```suggestion
	values. This way its possible to differentiate unsupported flags
```

> +	- *bsize*
+	- *blocks*
+	- *bfree*
+	- *bavail*
+	- *favail*
+	- *ffree*
+	- *files*
+	- *flag*
+	- *frsize*
+	- *fsid*
+	- *namemax*
+
+	If omitted, a table with all these fields is returned.
+
+	*flag* is table with known flag names as keys and booleans as
+	values. This way it's possible to differentiate unsupported flags

We should also document the currently supported (known) mount flags returned via the `flag` table: `rdonly` and `nosuid`.

> @@ -831,6 +831,37 @@ calls refer to the system manual, eg *access*(3) for *posix.access()*.
 	end
 	```
 
+*statvfs(*_PATH_*)*

```suggestion
*statvfs(*_PATH_ [, _SELECTOR_]*)*
```

> +	    }
+	    break;
+    case 10:lua_pushinteger(L, (lua_Integer)buf->f_namemax); break;
+    default: return 0;
+    }
+    return 1;
+}
+
+static const char *const Sstatvfs[] =
+{
+    "bsize",   "frsize", "blocks", "bfree", "bavail",
+    "files",   "ffree",  "favail", "fsid",  "flag",
+    "namemax", NULL
+};
+
+static int Pstatvfs(lua_State *L)		/** statvfs(path) */

```suggestion
static int Pstatvfs(lua_State *L)		/** statvfs(path,[selector]) */
```

> @@ -831,6 +831,37 @@ calls refer to the system manual, eg *access*(3) for *posix.access()*.
 	end
 	```
 
+*statvfs(*_PATH_*)*
+	Get filesystem *statvfs*(3) information about the filesystem at _PATH_.

To be more precise and consistent with the `statvfs(3)` man page, this should probably say something like:

```suggestion
	Get *statvfs*(3) information about a mounted filesystem where _PATH_ is a file within the filesystem.
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4324#pullrequestreview-5143599957
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/4324/review/5143599957 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20260908/aa1d29c0/attachment.htm>